Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bifrost] Auto provision logs metadata #2458

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Bifrost] Auto provision logs metadata #2458

wants to merge 3 commits into from

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Dec 24, 2024

BifrostService will not auto provision its own metadata entry in metadata store on startup.


Stack created with Sapling. Best reviewed with ReviewStack.

- BifrostAdmin can now init empty logs configuration
- BifrostAdmin can now auto extend the chain
- Providers now have control over suggesting a new segment configuration
- Introduces a temporary copy of NodeSetSelector into bifrost until log-controller is removed
…etadataWriter

This PR introduces two key changes:

1. Bifrost now can provide `bifrost.admin()` to get easy access to bifrost's admin interface withouto passing metadata writer and metadata store client explicitly.
2. MetadataWriter now owns MetadataStoreClient.


This means that you can always access metadata store client directly if you have metadata_writer which used to be a pair of types we _always_ pass together. This also opens a path for a future where MetadataWriter wraps the metadata store client and automatically update metadata manager on successful writes but that's beyond the scope of this PR. What this PR provides is a direct access to the underlying metadata_store_client via an accessor function.
Copy link

github-actions bot commented Dec 24, 2024

Test Results

  7 files  ±0    7 suites  ±0   4m 25s ⏱️ -14s
 47 tests ±0   46 ✅ ±0  1 💤 ±0  0 ❌ ±0 
182 runs  ±0  179 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit a8c0143. ± Comparison against base commit 1ac1f70.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman marked this pull request as ready for review December 24, 2024 17:04
BifrostService will not auto provision its own metadata entry in metadata store on startup.
@AhmedSoliman AhmedSoliman changed the title Auto provision logs metadata [Bifrost] Auto provision logs metadata Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant